Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency injection #964

Merged
merged 36 commits into from
Oct 19, 2024
Merged

Dependency injection #964

merged 36 commits into from
Oct 19, 2024

Conversation

sezanzeb
Copy link
Owner

@sezanzeb sezanzeb commented Oct 2, 2024 •
edited
Loading

Blocked by #960

  • Further simplifies the test setup, because instead of having to clean up global singletons, they are created from scratch in each test to the testers hearts desire.
  • Importing files doesn't have side-effects.
  • Dependencies can be replaced by MagicMock objects, narrowing down the scope of unit-tests.

Not all classes are transitioned to this pattern. See comment below.

@sezanzeb
wip
644f4c5
@sezanzeb
asdf
f705d5f
@sezanzeb
update usage for combinations
12a2d72
@sezanzeb
development.md hint for evedv imports and patches
88a13a9
@sezanzeb
don't you love it when things break overnight?
ea52f85
@sezanzeb
some mypy stuff
891b4e1
@sezanzeb
ladjsfkla
448f028
@sezanzeb
updated outdated assertion code or something
8e4e510
@sezanzeb
aldjkf
703d3ef
@sezanzeb
optimize imports
d8b9995
@sezanzeb
update copyright year, refactoring test lib
52b0210
@sezanzeb
unittest discover in github pipeline
a055911
@sezanzeb
Merge branch 'main' into improved_test_setup
9b1d0de
@sezanzeb
kasjdfa
203edb2
@sezanzeb
akldjsfa
04e5115
@sezanzeb
improved test_daemon
efdfd85
@sezanzeb
hopefully fixed test_daemon
2062941
@sezanzeb
minor cleanup
34ccf9c
@sezanzeb
updated docs, removed .run configurations
28de297
@sezanzeb
run all unit tests in github ci
e337025
@sezanzeb
removed redundant quick_cleanup calls
c0c884f
@sezanzeb
minor cleanup stuff
f2457eb
@sezanzeb
bump python version in ci
bb491ee
@sezanzeb
using pythons patch method everywhere else as well
c1d4e58
@sezanzeb
rename logger to logging
4f03e57
@sezanzeb
removed unused evdev wrapper
9e56742
@sezanzeb
Injecting GlobalConfig
57a7c07
@sezanzeb
more refactoring
e0a8127
@sezanzeb sezanzeb changed the base branch from main to improved_test_setup October 2, 2024 14:33
@sezanzeb sezanzeb force-pushed the dependency-injection branch from ebb0145 to e0a8127 Compare October 3, 2024 13:45
@sezanzeb sezanzeb force-pushed the dependency-injection branch from f8f21ce to 166792b Compare October 3, 2024 13:58
@sezanzeb
Copy link
Owner Author

sezanzeb commented Oct 3, 2024 •
edited
Loading

doing dependency injection for macros is rather difficult to do. In the end, the Mapping objects need the OutputParser (a class wrapping the def parse method and the others of that file) injected, which causes problems when serializing them. I haven't looked into it in more detail yet, as I didn't want to fiddle around more than I already did at that point.

But a little bit is done in this branch at least.

@sezanzeb sezanzeb mentioned this pull request Oct 16, 2024
Closed
@sezanzeb sezanzeb force-pushed the dependency-injection branch from 076b93e to a113698 Compare October 16, 2024 20:16
@sezanzeb sezanzeb marked this pull request as ready for review October 16, 2024 20:59
@sezanzeb sezanzeb requested a review from jonasBoss October 16, 2024 20:59
@sezanzeb sezanzeb changed the base branch from improved_test_setup to main October 16, 2024 20:59
jonasBoss
jonasBoss approved these changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@jonasBoss jonasBoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the changes, i think it simplifies things and makes it easier to test

@sezanzeb sezanzeb merged commit 057663a into main Oct 19, 2024
6 checks passed
@sezanzeb
Copy link
Owner Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasBoss jonasBoss jonasBoss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sezanzeb @jonasBoss